Skip to content

Initial spec.#1

Merged
bylicaatgoogle merged 43 commits into
mainfrom
start-spec
Jan 27, 2026
Merged

Initial spec.#1
bylicaatgoogle merged 43 commits into
mainfrom
start-spec

Conversation

@bylicaatgoogle
Copy link
Copy Markdown
Owner

@bylicaatgoogle bylicaatgoogle commented Nov 12, 2025

No description provided.

@bylicaatgoogle
Copy link
Copy Markdown
Owner Author

bylicaatgoogle commented Nov 13, 2025

@domfarolino

domfarolino
domfarolino reviewed Nov 18, 2025
View reviewed changes
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs
Comment thread index.bs
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
@domfarolino
Copy link
Copy Markdown
Collaborator

domfarolino commented Nov 18, 2025

Can you set up the auto-build for the bikeshed spec in the PR preview? Maybe something like https://github.com/WICG/fenced-frame/tree/master/.github/workflows

@bylicaatgoogle
Copy link
Copy Markdown
Owner Author

bylicaatgoogle commented Nov 26, 2025

https://github.com/bylicaatgoogle/web-printing-api/blob/main/.github/workflows/build.yml - set the auto-build up.

@bylicaatgoogle bylicaatgoogle force-pushed the start-spec branch 3 times, most recently from 56f466d to 490f577 Compare November 26, 2025 12:52
@bylicaatgoogle
Copy link
Copy Markdown
Owner Author

bylicaatgoogle commented Nov 28, 2025

@domfarolino, I addressed all of the comments. Let me know if this is a step in the right direction. And please let me know what else could I improve.

@bylicaatgoogle bylicaatgoogle force-pushed the start-spec branch 2 times, most recently from 78fbeff to 063bd54 Compare December 1, 2025 22:09
domfarolino
domfarolino reviewed Dec 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better. Watch out for instances of incorrect linking. E.g., {{cachedAttributes}} instead of {{WebPrinter/cachedAttributes()}}. I think. bikeshed requires the latter.

Also please set up PR previews (see https://github.com/WICG/fenced-frame/blob/master/.pr-preview.json) and an automatic build for PRs in the CI (see https://github.com/WICG/fenced-frame/blob/master/.github/workflows/build.yml).

Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs
bylicaatgoogle and others added 19 commits January 15, 2026 15:37
@bylicaatgoogle
Initial spec.
3094cfe
@bylicaatgoogle @domfarolino
Fix typo.
5fa826d 
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@bylicaatgoogle @domfarolino
Mention Window interface instead of WindowOrWorkerGlobalScope.
d31d053 
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@bylicaatgoogle
Add index.html to gitignore.
dc4b2e3
@bylicaatgoogle
Drop unnecessary definition tags.
0893e21
@bylicaatgoogle
Mention isolated contexts more directly.
78a3765
@bylicaatgoogle
Remove domfarolino from editors.
c0c2749
@bylicaatgoogle
Link to window.print.
4e7d384
@bylicaatgoogle
Rephrase the note about only printer name and id being available befo…
765b2ef 
…re fetchAttributes().
@bylicaatgoogle
Standardize the obfuscation/hashing algorithm for printer id.
dbad953
@bylicaatgoogle
Use a pre tag instead of xmp in js examples.
ccfdf4e
@bylicaatgoogle
Wrap algorithm steps in proper blocks.
d1d61b5
@bylicaatgoogle
Fix the resolving a promise step in getPrinters algorithm.
34bd351
@bylicaatgoogle
Remove unnecessary headers and consolidate idl.
14e873e
@bylicaatgoogle
Do not include index.html.
839f950
@bylicaatgoogle
Indent algorithm blocks correctly.
00e129d
@bylicaatgoogle
Remove more printer def references.
15d649d
@bylicaatgoogle
Fix foreach and setting fields in the getPrinters algorithm.
41f13db
@bylicaatgoogle
Add missing comma.
32890d1
bylicaatgoogle and others added 20 commits January 15, 2026 15:37
@bylicaatgoogle
Be more specific about malformed document data.
884ed22
@bylicaatgoogle
Iterate over template attributes more explicitly in the submitPrintJo…
f74ebfb 
…b algorithm.
@bylicaatgoogle
Iterate over printer capabilities in WebPrinter/fetchAttributes() mor…
3d79a97 
…e explicitly.
@bylicaatgoogle
Define the internal attributes fields of WebPrinter and WebPrintJob i…
c86ab68 
…n a nicer way.
@bylicaatgoogle
Fix other errors.
ec94fe5
@bylicaatgoogle
Use undefined instead of void.
cf93f5c
@bylicaatgoogle
Set default value for optional.
7e0ac05
@bylicaatgoogle @domfarolino
Use "ordinary" contexts naming.
fd8fdc3 
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@bylicaatgoogle @domfarolino
Call methods "methods".
5390878 
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@bylicaatgoogle
Ensure Window/printing is not a mixin.
535aa3a
@bylicaatgoogle
Refer to Window/printing explicitly.
30853ed
@bylicaatgoogle
Do not use exclamation marks.
95d6d9a
@bylicaatgoogle
Mention allocation of WebPrintingManager alongside Window.
1deb888
@bylicaatgoogle
Improve the getPrinters() algorithm.
af36733
@bylicaatgoogle
Fix linking.
5d15556
@bylicaatgoogle @domfarolino
Link to a definition of a set
af865ad 
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@bylicaatgoogle @domfarolino
Use "dictionary" instead of a n "object".
9595877 
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@bylicaatgoogle
Fix referencing a set.
7976d48
@bylicaatgoogle
Define |global| before going parallel and then use it.
39e1154
@bylicaatgoogle
Try to fix the workflows.
2302335
@bylicaatgoogle bylicaatgoogle merged commit bbcae4c into main Jan 27, 2026
1 check passed
github-actions Bot added a commit that referenced this pull request Jan 27, 2026
@bylicaatgoogle @github-actions
Merge pull request #1 from bylicaatgoogle/start-spec
c346b71 
SHA: bbcae4c
Reason: push, by bylicaatgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domfarolino domfarolino domfarolino left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bylicaatgoogle @domfarolino